Feat/doc editor skeleton #1491
Merged
Feat/doc editor skeleton #1491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ovgodd
force-pushed
the
feat/doc-editor-skeleton
branch
from
9707dc5 to
f976a72
Compare
|
Size Change: +1.34 kB (+0.04%) Total Size: 3.68 MB
|
Ovgodd
force-pushed
the
feat/doc-editor-skeleton
branch
from
f976a72 to
5b99563
Compare
AntoLC
reviewed
Oct 16, 2025
src/frontend/apps/impress/src/features/left-panel/components/DocCreationOverlay.tsx
Outdated
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/left-panel/components/DocCreationOverlay.tsx
Outdated
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/docs/doc-editor/components/DocEditorSkeleton.tsx
Outdated
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/docs/doc-editor/components/DocEditorSkeleton.tsx
Outdated
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/docs/doc-editor/components/DocEditorSkeleton.tsx
Outdated
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/docs/doc-editor/components/DocEditorSkeleton.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
As talk together, maybe something very generic could be nice (BooleanStore ?), with Record<string, boolean>; to be able to have multiple toggles here and there.
There was a problem hiding this comment.
As we talk together afterwards, ye created an useSkeletonStore as we just need it for this specific case for the moment
| overflow-x: clip; | ||
| `} | ||
| > | ||
| <DocCreationOverlay /> |
There was a problem hiding this comment.
Same I think it could be nice to have something more generic, that can be used for other things that DocCreation.
The problem that I find as well, is I get a bit the flickering effect, if we could implement a light transition before unmounting the skeleton would be great (fadeOut / fadeIn ?)
Ovgodd
force-pushed
the
feat/doc-editor-skeleton
branch
4 times, most recently
from
69846b2 to
09d8341
Compare
AntoLC
reviewed
Oct 22, 2025
src/frontend/apps/impress/src/features/skeletons/components/DocEditorSkeleton.tsx
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/skeletons/store/useSkeletonStore.tsx
Outdated
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/left-panel/components/LeftPanelHeaderButton.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
201
to
204
| // If we're in creation mode, the global skeleton is already displayed | ||
| // Otherwise, display the local skeleton | ||
| if (!doc) { | ||
| return <Loading />; | ||
| return isLoading ? null : <DocEditorSkeleton />; |
There was a problem hiding this comment.
You should not need to do that, if you want to have the skeleton displayed when the page load, you just have to activate the skeleton like that setLoading(true);, at the earliest moment so maybe in DocLayout ?
Ovgodd
force-pushed
the
feat/doc-editor-skeleton
branch
4 times, most recently
from
6c84664 to
caf41b3
Compare
Ovgodd
force-pushed
the
feat/doc-editor-skeleton
branch
5 times, most recently
from
546aeb5 to
9ce0640
Compare
AntoLC
approved these changes
Oct 23, 2025
Ovgodd
force-pushed
the
feat/doc-editor-skeleton
branch
2 times, most recently
from
602c2b2 to
de88a86
Compare
creating a skeleton to be display during doc creation Signed-off-by: Cyril <[email protected]>
Ovgodd
force-pushed
the
feat/doc-editor-skeleton
branch
from
de88a86 to
8b73aa3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Introduce a loading skeleton in the DocEditor and manage its visibility using Zustand. Ensure the loader is removed properly in case of errors to prevent it from staying stuck on screen.
issue : 1452
nothrotskeleton.mp4
Proposal